stk malloc/free bug

From: Jay Krell <jay.krell_at_cornell.edu>
Date: Thu, 14 Nov 1996 04:24:43 -0500

I'm not sure why, but this appeared to clear up a problem where the
VC debug malloc was reporting memory modified after being freed:

D:\stk-3.1.1>diff -c4 /original-stk-3.1.1/src/tcl-lib.c src/tcl-lib.c
*** /original-stk-3.1.1/src/tcl-lib.c Tue Sep 17 12:20:59 1996
--- src/tcl-lib.c Thu Nov 14 09:13:34 1996
***************
*** 345,352 ****
--- 345,353 ----
    hPtr = Tcl_CreateHashEntry(&iPtr->commandTable, cmdName, &new);
    if (!new) {
      /* Command already exists: delete the old one */
      Tcl_DeleteCommand(interp, cmdName); /* not efficient but safer */
+ hPtr = Tcl_CreateHashEntry(&iPtr->commandTable, cmdName, &new);
    }
    Tcl_SetHashValue(hPtr, W);

    /* Define a Tk-command cell for this new command */

The report was apparently triggered around here in src/tk-main.c:
  /* Initialize commands which are now in Tcl */
  Tcl_CreateCommand(STk_main_interp, "after", Tcl_AfterCmd, NULL, NULL);
  Tcl_CreateCommand(STk_main_interp, "update", Tcl_UpdateCmd, NULL, NULL);

 - Jay, jay.krell_at_cornell.edu
Received on Thu Nov 14 1996 - 13:20:14 CET