Bug(?) in Src/argv.c

From: Nicholas Vargish <vargish_at_mailbox.ser.bbnplanet.com>
Date: Fri, 09 Feb 1996 09:49:08 -0500

Hi,

While playing with STk under comint-mode for Emacs (I'm just not happy
with ilisp or xscheme :^), I discovered what could be an error in
argv.c:

vargish_at_tanelorn$ stk ""
"-geometry" option requires an additional argument
vargish_at_tanelorn$

That is, the empty string is matched to "-geometry", which is not
correct. It's my suspicion that the empty string, if passed as an
argument, should be ignored. At least, this behavior won't crash my
invocation of make-comint.

Here's the context diff to fix this behavior:

================================================== BEGIN CONTEXT DIFF

*** Src/argv.c.ORIG Fri Feb 9 09:27:13 1996
--- Src/argv.c Fri Feb 9 09:32:41 1996
***************
*** 100,105 ****
--- 100,108 ----
      char *arg = *++argv;
      int found = FALSE;
  
+ if (! *arg)
+ continue;
+
      for (p = Table; *(p->key); p++) {
        if (strstr(p->key, arg)== p->key) {
        found = TRUE;

================================================== END CONTEXT DIFF

Not a big problem, which means I knew how to fix it. :^)

Cheers,

Nick

 +------------------------------------+
 | Nick Vargish, BBN Planet (SURAnet) | If I knew who God was, I'd
 | vargish_at_sura.net 301/489-8134 | thank Her.
 | http://www.sura.net/~vargish | [Garibaldi, Babylon 5]
Received on Fri Feb 09 1996 - 15:52:15 CET

This archive was generated by hypermail 2.3.0 : Mon Jul 21 2014 - 19:38:59 CEST